08bc2add6e98feefdce36f6f094a15e3e598b1e7,src/python/pants/engine/exp/mapper.py,AddressMap,parse,#Any#Any#Any#Any#,39

Before Change

    :type parser_cls: A :class:`pants.engine.exp.parser.Parser`
    
    objects = parser_cls.parse(path, symbol_table_cls)
    objects_by_name = {}
    for obj in objects:
      if not Serializable.is_serializable(obj):
        raise UnaddressableObjectError("Parsed a non-serializable object: {!r}".format(obj))
      attributes = obj._asdict()

      name = attributes.get("name")
      if not name:
        raise UnaddressableObjectError("Parsed a non-addressable object: {!r}".format(obj))

      if name in objects_by_name:
        raise DuplicateNameError("An object already exists at {!r} with name {!r}: {!r}.  Cannot "
                                 "map {!r}".format(path, name, objects_by_name[name], obj))

      objects_by_name[name] = obj
    return cls(path, objects_by_name)

After Change

        previous = objects_by_name.get(name)
        if previous:
          previous_path, _ = previous
          raise DuplicateNameError("An object with name {name!r} is already defined in "
                                   "{previous_path!r}, will not overwrite with {obj!r} from "
                                   "{current_path!r}."
                                   .format(name=name,
                                           previous_path=previous_path,

Instances