cafe7cc9cd3678163cf50ac554b723ce226f268f,src/bql.py,,_create_population,#Any#Any#,683

Before Change

        if stattype == "numerical":
            qt = sqlite3_quote_name(phrase.table)
            cursor = bdb.sql_execute("SELECT %s FROM %s" % (var, qt))
            rows = cursor.fetchall()
            if any(isinstance(r[0], (unicode, str)) for r in rows):
                numerical_string_vars.append(var)
    if len(numerical_string_vars) > 0:
        raise BQLError(
            bdb, "Column(s) with string values modeled as numerical: %r"
            % (numerical_string_vars, ))

After Change

        pop_guess_vars = []

    // Ensure no string-valued variables are being modeled as numerical.
    numerical_string_vars = [
        var for var, stattype in pop_model_vars
        if stattype == "numerical"
            and _column_contains_string(bdb, phrase.table, var)
    ]
    if numerical_string_vars:
        raise BQLError(bdb,
            "Column(s) with string values modeled as numerical: %r"
            % (numerical_string_vars, ))

Instances