79d358a10723d9a1c9cef7aed16ccc5a693f3f6c,tests/python/pants_test/backend/jvm/targets/test_jvm_binary.py,JvmBinaryTest,test_manifest_bad_key,#JvmBinaryTest#,164

Before Change

    with self.assertRaisesRegexp(ManifestEntries.ExpectedDictionaryError,
                                 r"^entries must be dictionary of strings, got key .* "
                                 r"type JarDependency$"):
      self.make_target(":foo",
                       JvmBinary,
                       main="com.example.Foo",
                       manifest_entries={JarDependency("bad", "bad", "bad"): "foo"})

  def test_manifest_entries_fingerprint(self):
    field1 = ManifestEntries()
    field2 = ManifestEntries({"Foo-Field": "foo"})

After Change

                                 r"dict. got (str|unicode)"):
      self.target(":foo")

  def test_manifest_bad_key(self):
    self.add_to_build_file(
      "",
      """jvm_binary(
  name = "foo",
  main = "com.example.Foo",
  manifest_entries = {jar("bad", "bad", "bad"): "foo"},
)""")
    with self.assertRaisesRegexp(TargetDefinitionException,
                                 r"entries must be dictionary of strings, got key .* "
                                 r"type JarDependency"):
      self.target(":foo")

  def test_manifest_entries_fingerprint(self):
    field1 = ManifestEntries()
    field2 = ManifestEntries({"Foo-Field": "foo"})

Instances