44e7ef0b2b8218781b5fe7e2191b9790c42d73ec,app/grandchallenge/container_exec/tasks.py,,validate_docker_image_async,#,15

Before Change

            instance.image.save(uploaded_image.name, File(f))

    manifest = _extract_docker_image_file(model, instance, "manifest.json")
    manifest = json.loads(manifest)

    if len(manifest) != 1:
        model.objects.filter(pk=pk).update(
            status=(
                f"The container image file should only have 1 image. "
                f"This file contains {len(manifest)}."
            )
        )
        raise ValidationError("Invalid Dockerfile")

    image_sha256 = manifest[0]["Config"][:64]

    config = _extract_docker_image_file(
        model, instance, f"{image_sha256}.json"
    )

After Change

        with uploaded_image.open() as f:
            instance.image.save(uploaded_image.name, File(f))

    try:
        image_sha256 = _validate_docker_image_manifest(
            model=model, instance=instance
        )
    except ValidationError:
        send_invalid_dockerfile_email(container_image=instance)
        raise

    model.objects.filter(pk=instance.pk).update(
        image_sha256=f"sha256:{image_sha256}", ready=True
    )

Instances