506b234094009d55d326f1ce957f53f15d4b65ee,geomstats/spd_matrices_space.py,SPDMetric,log,#SPDMetric#Any#Any#,182

Before Change

        sqrt_base_point = scipy.linalg.sqrtm(base_point)
        inv_sqrt_base_point = np.linalg.inv(sqrt_base_point)

        point_near_id = np.dot(np.dot(inv_sqrt_base_point,
                                      point),
                               inv_sqrt_base_point)
        log_at_id = group_log(point_near_id)

        log = np.dot(np.dot(sqrt_base_point,
                            log_at_id),

After Change

        This gives a tangent vector at point base_point.
        
        if point.ndim == 2:
            point = np.expand_dims(point, axis=0)
        assert point.ndim == 3

        if base_point.ndim == 2:
            base_point = np.expand_dims(base_point, axis=0)
        assert base_point.ndim == 3

        n_points, _, _ = point.shape
        n_base_points, mat_dim, _ = base_point.shape

        assert (n_points == n_base_points
                or n_points == 1
                or n_base_points == 1)

        sqrt_base_point = np.zeros((n_base_points, mat_dim, mat_dim))
        for i in range(n_base_points):
            sqrt_base_point[i] = scipy.linalg.sqrtm(base_point[i])

        inv_sqrt_base_point = np.linalg.inv(sqrt_base_point)

        point_near_id = np.matmul(inv_sqrt_base_point, point)
        point_near_id = np.matmul(point_near_id, inv_sqrt_base_point)
        log_at_id = group_log(point_near_id)

        log = np.matmul(sqrt_base_point, log_at_id)
        log = np.matmul(log, sqrt_base_point)

        return log

Instances