557aef062fd907e6dec11acfa5525d2d859d29a7,dino/db/rdbms/handler.py,DatabaseRdbms,leave_room,#DatabaseRdbms#Any#Any#,245

Before Change

    @with_session
    def leave_room(self, user_id: str, room_id: str) -> None:
        raise NotImplementedError()

    @with_session
    def join_room(self, user_id: str, user_name: str, room_id: str, room_name: str) -> None:
        room = self.session.query(Rooms).filter(Rooms.uuid == room_id).first()

After Change

    @with_session
    def leave_room(self, user_id: str, room_id: str) -> None:
        room = self.session.query(Rooms).filter(Rooms.uuid == room_id).first()
        if room is None:
            raise NoSuchRoomException(room_id)

        user = self.session.query(Users)\
            .join(Users.rooms)\
            .filter(Users.uuid == user_id)\
            .filter(Rooms.uuid == room_id)\
            .first()

        if user is None:
            // user is not in the room, so nothing to do
            return

        room = user.rooms[0]
        room.users.remove(user)
        self.session.commit()

Instances