4da37abc3937edf62249daa010f5e522c6c04fd4,perfkitbenchmarker/providers/aws/aws_managed_relational_db.py,AwsManagedRelationalDb,_IsInstanceReady,#AwsManagedRelationalDb#Any#Any#,480

Before Change

      True if the resource was ready in time, False if the wait timed out
        or an Exception occurred.
    
    cmd = util.AWS_PREFIX + [
        "rds",
        "describe-db-instances",
        "--db-instance-identifier=%s" % instance_id,
        "--region=%s" % self.region
    ]
    start_time = datetime.datetime.now()

    while True:
      if (datetime.datetime.now() - start_time).seconds >= timeout:
        logging.exception("Timeout waiting for sql instance to be ready")
        return False
      stdout, _, _ = vm_util.IssueCommand(cmd, suppress_warning=True)

      try:
        json_output = json.loads(stdout)
        state = json_output["DBInstances"][0]["DBInstanceStatus"]

After Change

      if (datetime.datetime.now() - start_time).seconds >= timeout:
        logging.exception("Timeout waiting for sql instance to be ready")
        return False
      json_output = self._DescribeInstance(instance_id)
      try:
        state = json_output["DBInstances"][0]["DBInstanceStatus"]
        pending_values = json_output["DBInstances"][0]["PendingModifiedValues"]
        logging.info("Instance state: %s", state)
        if pending_values:
          logging.info("Pending values: %s", (str(pending_values)))

        if state == "available" and not pending_values:
          break
      except:
        logging.exception("Error attempting to read stdout. Creation failure.")

Instances