555363bd1809fa6acd15e3e61f0a45a38c1ca7d5,tests/python/pants_test/base/test_exception_sink.py,TestExceptionSink,test_set_invalid_log_location,#TestExceptionSink#,33

Before Change

  def test_set_invalid_log_location(self):
    self.assertFalse(os.path.isdir("/does/not/exist"))
    sink = self._gen_sink_subclass()
    err_rx = re.escape(
      "The provided exception sink path at "/does/not/exist" is not writable or could not be created: [Errno 13]")
    with self.assertRaisesRegexp(ExceptionSink.ExceptionSinkError, err_rx):
      sink.reset_log_location("/does/not/exist")

After Change

    // creating a new directory with safe_mkdir(), Linux errors out trying to create the directory
    // for its log files with safe_open(). This may be due to differences in the filesystems.
    // TODO: figure out why we error out at different points here!
    err_str = Platform.current.match({
      Platform.darwin: "The provided exception sink path at "/" is not writable or could not be created: [Errno 21] Is a directory: "/".",
      Platform.linux: "Error opening fatal error log streams for log location "/": [Errno 13] Permission denied: "/.pids""
    })
    with self.assertRaisesWithMessageContaining(ExceptionSink.ExceptionSinkError, err_str):
      sink.reset_log_location("/")

  def test_log_exception(self):

Instances