c1f116ffdced6cf3705b37868e55c4e2b258650b,geomstats/geometry/special_orthogonal.py,SpecialOrthogonal,regularize_tangent_vec,#SpecialOrthogonal#Any#Any#Any#Any#,262

Before Change

                // TODO(nina): Check if/how regularization is needed in nD?
                regularized_tangent_vec = tangent_vec

        elif point_type == "matrix":
            regularized_tangent_vec = tangent_vec

        return regularized_tangent_vec

After Change

            if gs.allclose(base_point, self.identity):
                return self.regularize_tangent_vec_at_identity(
                    tangent_vec, point_type=point_type)
            inv_base_point = self.inverse(base_point)
            tangent_vec_at_id = self.compose(inv_base_point, tangent_vec)
            regularized_tangent_vec = self.regularize_tangent_vec_at_identity(
                tangent_vec_at_id, point_type=point_type)
            regularized_tangent_vec = self.compose(
                base_point, regularized_tangent_vec)

        else:
            raise ValueError("point_type should be \"vector\" or \"matrix\".")

Instances