e42009c466dbb77532a96f7ce61cda68c4cc2708,django/comicsite/views.py,,inserted_file,#Any#Any#Any#,283

Before Change

        
    
     
    if not hasattr(settings,"COMIC_PUBLIC_FOLDER_NAME"):
        raise ImproperlyConfigured("Don"t know from which folder serving files is allowed. Please add a setting \
                                    "COMIC_PUBLIC_FOLDER_NAME = \"public_html\" to your .conf file." )
 
    if not filepath.startswith(settings.COMIC_PUBLIC_FOLDER_NAME):
        //FIXME:  throw 403 or proper permission denied here
        raise Http404("Permission Denied. Only objects in folder named "%s" can be served without credentials\
                       FIXME: throw proper 403 or permission denied here." % settings.COMIC_PUBLIC_FOLDER_NAME )        

After Change

    filename = path.join(settings.DROPBOX_ROOT,site_short_name,filepath)
    
    
    if can_access(request.user,          
                  filename,
                  site_short_name,          
                  override_permission=ComicSiteModel.REGISTERED_ONLY):
        
        try:            
            file = open(filename,"rb")        

Instances