91f0e27b4d7e94e0e5cafe1c2a6fb37c80ab8b41,contrib/go/tests/python/pants_test/contrib/go/tasks/test_go_compile_integration.py,GoCompileIntegrationTest,test_go_compile_simple,#GoCompileIntegrationTest#,20

Before Change

      self.assert_success(pants_run)
      // TODO(jsirois): Kill this check and the GoTool utility by using Go subsystem
      if GoTool.go_installed():
        goos = subprocess.check_output(["go", "env", "GOOS"]).strip()
        goarch = subprocess.check_output(["go", "env", "GOARCH"]).strip()
        expected_files = set("contrib.go.examples.src.go.{libname}.{libname}/"
                             "pkg/{goos}_{goarch}/contrib/go/examples/src/go/{libname}.a"

After Change

              "contrib/go/examples/src/go/libA"]
      pants_run = self.run_pants_with_workdir(args, workdir)
      self.assert_success(pants_run)
      with subsystem_instance(GoDistribution.Factory) as factory:
        go_dist = factory.create()
        goos = go_dist.create_go_cmd("env", args=["GOOS"]).check_output().strip()
        goarch = go_dist.create_go_cmd("env", args=["GOARCH"]).check_output().strip()
        expected_files = set("contrib.go.examples.src.go.{libname}.{libname}/"
                             "pkg/{goos}_{goarch}/{libname}.a"
                             .format(libname=libname, goos=goos, goarch=goarch)
                             for libname in ("libA", "libB", "libC", "libD", "libE"))
        self.assert_contains_exact_files(os.path.join(workdir, "compile", "go"),
                                         expected_files)

Instances