6c2b0bc69e167dafec15ec3e66066be8ed41bf22,dino/validation/acl.py,AclValidator,is_acl_valid,#AclValidator#Any#Any#,169

Before Change

    }

    def is_acl_valid(self, acl_type, acl_value):
        validator = AclValidator.ACL_VALIDATORS.get(acl_type, None)
        if validator is None:
            return False
        if not callable(validator):
            return False

After Change

        all_acls = environ.env.config.get(ConfigKeys.ACL)
        all_validators = all_acls["validation"]

        if acl_type not in all_validators:
            logger.warn("acl type "%s" does not have a validator" % acl_type)
            return False

        validator_func = all_validators[acl_type]["value"]
        if not callable(validator_func):
            logger.error("validator for acl type "%s" is not callable" % acl_type)
            return False
        if not isinstance(validator_func, BaseAclValidator):
            logger.error(
                    "validator for acl type "%s" is not of instance BaseAclValidator but "%s"" %
                    (acl_type, str(type(validator_func))))
            return False

        // blank means we"re removing it

Instances