5a53f60e5143ab6f416437dadddd2f1df133a247,pgmpy/models/JunctionTree.py,JunctionTree,check_model,#JunctionTree#,238

Before Change

            True if all the checks are passed
        
        for clique in self.nodes():
            if self.get_factors(clique):
                pass
            else:
                raise ValueError("Factors for all the cliques or clusters not"
                                 "defined.")

        if len(self.factors) != len(self.nodes()):
            raise ValueError("One to one mapping of factor to clique or cluster"
                             "is not there.")

        for factor in self.factors:
            for variable, cardinality in zip(factor.scope(), factor.cardinality):
                if ((self.cardinalities[variable]) and
                        (self.cardinalities[variable] != cardinality)):
                    raise CardinalityError(

After Change

        if not nx.is_connected(self):
            raise ValueError("The Junction Tree defined is not fully connected.")

        return super().check_model()

Instances