14759e1065e307c7760299670da30f64ffdbf783,src/python/pants/engine/engine.py,LocalMultiprocessEngine,_submit_until,#LocalMultiprocessEngine#Any#Any#Any#,450

Before Change


        if step.step_id in in_flight:
          raise InFlightException("{} is already in_flight!".format(step))

        step = self._storage.key_for_request(step)
        result = self._maybe_cache_get(step)
        if result is not None:
          // Skip in_flight on cache hit.
          promise.success(result)
        else:

After Change


      result = self._cache.get_for_key(runnable_key) if is_cacheable else None
      if result is not None:
        // Skip in_flight on cache hit.
        completed.append((step, result))
      else:
        step_id = id(step)
        in_flight[step_id] = step
Italian Trulli
In pattern: SUPERPATTERN

Frequency: 3

Non-data size: 4

Instances


Project Name: pantsbuild/pants
Commit Name: 14759e1065e307c7760299670da30f64ffdbf783
Time: 2016-08-27
Author: stuhood@gmail.com
File Name: src/python/pants/engine/engine.py
Class Name: LocalMultiprocessEngine
Method Name: _submit_until


Project Name: pantsbuild/pants
Commit Name: beaa459cdb6bd0819f01df29b24260fc8724a19f
Time: 2016-06-03
Author: stuhood@gmail.com
File Name: src/python/pants/engine/engine.py
Class Name: LocalSerialEngine
Method Name: reduce


Project Name: pantsbuild/pants
Commit Name: 14759e1065e307c7760299670da30f64ffdbf783
Time: 2016-08-27
Author: stuhood@gmail.com
File Name: tests/python/pants_test/engine/test_storage.py
Class Name: CacheTest
Method Name: setUp