9334d336f027e8b90d5751458c7794f8a0167559,thinc/shims/mxnet.py,MXNetShim,finish_update,#MXNetShim#Any#,59

Before Change

    def finish_update(self, optimizer):
        if self._optimizer is None:
            self._optimizer, self._trainer = self._create_optimizer(optimizer)
        if getattr(optimizer, "grad_clip", None):
            ctx = mx.current_context()
            grads = [

After Change

    def finish_update(self, optimizer: Optimizer):
        for value in self._model.collect_params().values():
            grad = cast(FloatsXd, mxnet2xp(value.grad()))
            param = cast(FloatsXd, mxnet2xp(value.data()))
            param, _ = optimizer((value.name, value.name), param, grad)
            value.set_data(xp2mxnet(param))

    def copy(self, ctx: "mx.context.Context" = None):

Instances