ffaad7649566c35b015694219f73aba8b6705902,src/fonduer/utils/utils_udf.py,,add_keys,#Any#Any#Any#,129

Before Change

        existing_keys = set(k.name for k in session.query(key_table).all())
        new_keys = set(keys).difference(existing_keys)
        // Bulk insert all new feature keys
        if new_keys:
            try:
                session.execute(
                    key_table.__table__.insert(), [{"name": key} for key in new_keys]
                )
                session.commit()
                return
            except Exception:
                continue
        else:
            // All keys have been inserted already
            return

After Change

    // Rather than deal with concurrency of querying first then inserting only
    // new keys, insert with on_conflict_do_nothing.
    stmt = insert(key_table.__table__).values([{"name": key} for key in keys])
    stmt = stmt.on_conflict_do_nothing(constraint=key_table.__table__.primary_key)
    session.execute(stmt)

Instances