f2754e0656d8cebe1f785f6af100e4ade241a7f8,thinc/model.py,Model,finish_update,#Model#Any#,371

Before Change

                // Kind of ugly to use the _mem.weights -- would make more sense
                // to call node.finish_update. Maybe we could pass in a set
                // of visited?
                optimizer(node._mem.weights, node._mem.gradient, key=node.id)
                seen.add(node.id)
                for shim in node.shims:
                    shim.finish_update(optimizer)

After Change

        
        for node in self.walk():
            for name in node.param_names:
                if node.has_grad(name):
                    param = node.get_param(name)
                    grad = node.get_grad(name)
                    param, grad = optimizer(param, grad, key=(node.id, name))
                    node.set_param(name, param)
                    node.set_grad(name, grad)
            for shim in node.shims:
                shim.finish_update(optimizer)

    @contextlib.contextmanager

Instances