238143038b99eb087b513e7052a494bc3de6db75,src/python/pants/bin/goal_runner.py,GoalRunner,setup,#GoalRunner#,53

Before Change

    with self.run_tracker.new_workunit(name="bootstrap", labels=[WorkUnit.SETUP]):
      // construct base parameters to be filled in for BuildGraph
      for path in self.options.for_global_scope().bootstrap_buildfiles:
        build_file = self.address_mapper.from_cache(root_dir=self.root_dir, relpath=path)
        // TODO(pl): This is an unfortunate interface leak, but I don"t think
        // in the long run that we should be relying on "bootstrap" BUILD files
        // that do nothing except modify global state.  That type of behavior
        // (e.g. source roots, goal registration) should instead happen in
        // project plugins, or specialized configuration files.
        self.build_file_parser.parse_build_file_family(build_file)

    self._expand_goals_and_specs()

    // Now that we"ve parsed the bootstrap BUILD files, and know about the SCM system.
    self.run_tracker.run_info.add_scm_info()

After Change

    // TODO(John Sirois): Kill when source root registration is lifted out of BUILD files.
    with self.run_tracker.new_workunit(name="bootstrap", labels=[WorkUnit.SETUP]):
      source_root_bootstrapper = SourceRootBootstrapper.global_instance()
      source_root_bootstrapper.bootstrap(self.address_mapper, self.build_file_parser)

    self._expand_goals_and_specs()

Instances