a15c8e19f9270ba69758528b0df2cfc362b601af,pyntcloud/geometry/coord_systems.py,,cylindrical_to_spherical,#Any#Any#Any#Any#Any#,172

Before Change

        "phi". Polar angle.
    

    radial_out = np.sqrt((radial * radial) + (height * height))
    azimuthal = angular

    if theta_is_inclination:
        polar = np.arctan(radial / height)
    else:
        polar = np.arctan(height / radial)

    // some weird arctan shit
    need_fix_arctan = np.logical_and(np.logical_and(radial > 0, height < 0),
                                     polar < 0)
    polar[need_fix_arctan] = abs(polar[need_fix_arctan]) + (np.pi / 2)

    if degrees:
        polar = np.rad2deg(polar)

    return radial_out, azimuthal, polar

After Change

    if phi_is_inclination:
        phi = np.arctan2(ro, zeta)
    else:
        phi = np.arctan2(zeta, ro)

    if degrees:
        phi = np.rad2deg(phi)

    return r, theta, phi


def spherical_to_cylindrical(r, theta, phi, degrees=True, phi_is_inclination=False):
    

Instances