ad9f8480c8e08b95d6c217ec4a126bd93b7f376a,tests/python/pants_test/backend/jvm/tasks/test_scalastyle.py,ScalastyleTest,test_get_non_synthetic_scala_targets,#ScalastyleTest#,118

Before Change

    // scala_library would bring in "scala-library defined in BUILD.tools
    // so we have an extra target here.
    self.assertEqual(5, len(context.targets()))

    // Now create the task and run the non_synthetic scala-only filtering.
    task = self._create_scalastyle_task_from_context(context)
    result_targets = task.get_non_synthetic_scala_targets(context.targets())

After Change

  def test_get_non_synthetic_scala_targets(self):
    with self.scala_platform_setup():
      // scala_library - should remain.
      scala_target = self.make_target("a/scala:s", ScalaLibrary, sources=["Source.scala"])

      // scala_library but with java sources - should be filtered
      scala_target_with_java_source = self.make_target("a/scala_java:sj",
                                                       ScalaLibrary,
                                                       sources=["Source.java"])

      // java_library - should be filtered
      java_target = self.make_target("a/java:j", JavaLibrary, sources=["Source.java"])

      // synthetic scala_library - should be filtered
      synthetic_scala_target = self.make_target("a/synthetic_scala:ss",
                                                ScalaLibrary,
                                                sources=["SourceGenerated.scala"],
                                                derived_from=scala_target)

      result_targets = Scalastyle.get_non_synthetic_scala_targets([java_target,
                                                                   scala_target,
                                                                   scala_target_with_java_source,

Instances