32f2649c5cda9acca3354e3246d798d8e0cec5dc,optuna/storages/_rdb/storage.py,RDBStorage,_get_trials,#RDBStorage#Any#Any#,929

Before Change

        if len(excluded_trial_ids) >= self._get_trials_failed_excluded_trial_ids_len:
            trial_models = self._get_trial_models_inclusive(study_id, excluded_trial_ids, session)
        else:
            try:
                trial_models = (
                    session.query(models.TrialModel)
                    .filter(
                        ~models.TrialModel.trial_id.in_(excluded_trial_ids),
                        models.TrialModel.study_id == study_id,
                    )
                    .all()
                )
            except OperationalError as e:
                // Likely exceeding the number of maximum allowed variables. This number differ
                // between database dialects. For SQLite for instance,
                // see https://www.sqlite.org/limits.html and the section describing
                // SQLITE_MAX_VARIABLE_NUMBER.

                _logger.warning(
                    "Caught an error from sqlalchemy: {}. Falling back to a slower alternative. "
                    "".format(str(e))
                )

                // Bookkeeping to circumvent the same error in the next call.
                self._get_trials_failed_excluded_trial_ids_len = len(excluded_trial_ids)

                trial_models = self._get_trial_models_inclusive(
                    study_id, excluded_trial_ids, session
                )

        trials = [self._build_frozen_trial_from_trial_model(trial) for trial in trial_models]

        self._commit(session)

After Change

            .filter(models.TrialModel.study_id == study_id,)
            .all()
        )
        trial_ids = set(trial_id_tuple[0] for trial_id_tuple in trial_ids)
        trial_ids -= excluded_trial_ids
        trial_models = (
            session.query(models.TrialModel)
            .filter(
                models.TrialModel.trial_id.in_(trial_ids), models.TrialModel.study_id == study_id,

Instances