91855bdc8c0dcb933821be0fdb356cc43ffce585,reframe/frontend/dependency.py,,validate_deps,#Any#,81

Before Change

    // Check for cyclic dependencies in the test name graph
    visited = set()
    unvisited = list(
        itertools.zip_longest(test_graph.keys(), [], fillvalue=None)
    )
    path = []
    while unvisited:
        node, parent = unvisited.pop()
        while path and path[-1] != parent:

After Change

    // Check for cyclic dependencies in the test name graph
    visited = set()
    sources = set(test_graph.keys())
    path = []

    // Since graph may comprise multiple not connected subgraphs, we search for
    // cycles starting from all possible sources
    while sources:
        unvisited = [(sources.pop(), None)]
        while unvisited:
            node, parent = unvisited.pop()
            while path and path[-1] != parent:
                path.pop()

            adjacent = reversed(test_graph[node])
            path.append(node)
            for n in adjacent:
                if n in path:
                    cycle_str = "->".join(path + [n])
                    raise DependencyError(
                        "found cyclic dependency between tests: " + cycle_str)

                if n not in visited:
                    unvisited.append((n, node))

            visited.add(node)

        sources -= visited

Instances