c83f6f17866a3d114c174ba282e4dff2fd9996f7,src/python/pants/cache/artifact.py,TarballArtifact,extract,#TarballArtifact#,111

Before Change

        // the same directory, so T1 throws "File exists" in B).
        // This actually happened, and was very hard to debug.
        // Creating the paths here up front allows us to squelch that "File exists" error.
        paths = []
        dirs = set()
        for tarinfo in tarin.getmembers():
          paths.append(tarinfo.name)
          if tarinfo.isdir():
            dirs.add(tarinfo.name)
          else:
            dirs.add(os.path.dirname(tarinfo.name))
        for d in dirs:
          try:
            os.makedirs(os.path.join(self._artifact_root, d))
          except OSError as e:

After Change

  def extract(self):
    // Note(yic): unlike the python implementation before, now we do not update self._relpath
    // after the extraction.
    try:
      self.NATIVE_BINARY.decompress_tarball(self._tarfile.encode("utf-8"),
                                            self._artifact_root.encode("utf-8"))
    except Exception as e:
      raise ArtifactError("Extracting artifact failed:\n{}".format(e))

Instances