ee50791d77ee69305a55e9d5b47fed12076411f4,src/python/pants/bin/remote_pants_runner.py,RemotePantsRunner,_connect_and_execute,#RemotePantsRunner#Any#,161

Before Change

            metadata_base_dir=pantsd_handle.metadata_base_dir,
        )

        timeout = global_options.pantsd_pailgun_quit_timeout
        pantsd_signal_handler = PailgunClientSignalHandler(client, pid=pid, timeout=timeout)
        with ExceptionSink.trapped_signals(pantsd_signal_handler), STTYSettings.preserved():
            // Execute the command on the pailgun.
            return client.execute(self._args[0], self._args[1:], modified_env)

    def _extract_remote_exception(self, pantsd_pid, nailgun_error):
        Given a NailgunError, returns a Terminated exception with additional info (where
        possible).

After Change

        }

        command = self._args[0]
        args = self._args[1:]

        def signal_fn() -> bool:
            return ExceptionSink.signal_sent() is not None

        rust_nailgun_client = native.new_nailgun_client(port=port)
        pantsd_signal_handler = PailgunClientSignalHandler(pid=pid)

        retries = 3
        attempt = 1
        while True:
            logger.debug(f"Connecting to pantsd on port {port} attempt {attempt}/{retries}")

            with ExceptionSink.trapped_signals(pantsd_signal_handler), STTYSettings.preserved():
                try:
                    output = rust_nailgun_client.execute(signal_fn, command, args, modified_env)
                    return output

                // NailgunConnectionException represents a failure connecting to pantsd, so we retry
                // up to the retry limit.
                except native.lib.NailgunConnectionException as e:
                    if attempt > retries:
                        raise self.Fallback(e)

                    // Wait one second before retrying
                    logger.warning(f"Pantsd was unresponsive on port {port}, retrying.")
                    time.sleep(1)
                    attempt += 1

Instances