7bae3828c7149d6d2a409c1236f25f699be92b66,pfnopt/storage/rdb.py,RDBStorage,get_all_trials,#RDBStorage#Any#,245

Before Change

        trials = self.session.query(Trial). \
            filter(Trial.study_id == study_id).all()

        return [self.get_trial(t.trial_id) for t in trials]

    def close(self):
        // type: () -> None
        self.session.close()

After Change

        trials = self.session.query(Trial).filter(Trial.study_id == study_id).all()
        params = self.session.query(TrialParam).join(Trial). \
            filter(Trial.study_id == study_id).all()
        values = self.session.query(TrialValue).join(Trial). \
            filter(Trial.study_id == study_id).all()

        return self._merge_queried_results(trials, params, values)

    @staticmethod
    def _merge_queried_results(trials, trial_params, trial_intermediate_values):
        // type: (List[Trial], List[TrialParam], List[TrialValue]) -> List[trial_module.Trial]

Instances