24d8a1652b3bf99115c67ba9f47e06b172fe8e00,src/python/pants/engine/exp/mapper.py,AddressMap,parse,#Any#Any#Any#,33

Before Change

    
    parse = parse or parsers.parse_json
    with open(path, "r") as fp:
      objects = parse(fp.read())
      objects_by_name = {}
      for obj in objects:
        if not Serializable.is_serializable(obj) or not obj._asdict().get("name"):
          raise UnaddressableObjectError("Parsed a non-addressable object: {!r}".format(obj))
        attributes = obj._asdict()
        name = attributes["name"]
        if name in objects_by_name:
          raise DuplicateNameError("An object already exists at {!r} with name {!r}: {!r}.  Cannot "
                                   "map {!r}".format(path, name, objects_by_name[name], obj))
        objects_by_name[name] = obj
      return cls(path, objects_by_name)

  def __init__(self, path, objects_by_name):
    Not intended for direct use, instead see `parse`.

After Change

                  addressable Serializable objects parsed from it.
    
    parse = parser or parsers.parse_json
    objects = parse(path)
    objects_by_name = {}
    for obj in objects:
      if not Serializable.is_serializable(obj):
        raise UnaddressableObjectError("Parsed a non-serializable object: {!r}".format(obj))
      attributes = obj._asdict()

      name = attributes.get("name")
      if not name:
        raise UnaddressableObjectError("Parsed a non-addressable object: {!r}".format(obj))

      if name in objects_by_name:
        raise DuplicateNameError("An object already exists at {!r} with name {!r}: {!r}.  Cannot "
                                 "map {!r}".format(path, name, objects_by_name[name], obj))

      objects_by_name[name] = obj
    return cls(path, objects_by_name)

  def __init__(self, path, objects_by_name):
    Not intended for direct use, instead see `parse`.

Instances