1cde31a291ae4ef70de9698bb019d6916d29afdb,cscs-checks/compile/libsci_acc_symlink.py,LibSciAccSymLinkTest,__init__,#LibSciAccSymLinkTest#Any#,23

Before Change

        prgenv = re.match(regex, lib_name).group("prgenv")

        // FIXME: Remove this logic after daint upgrade
        if prgenv == "gnu":
            cver = re.match(regex, lib_name).group("cver")
            if cver == "71":
                self.valid_systems += ["daint:login", "daint:gpu"]
            else:
                self.valid_systems += ["dom:login", "dom:gpu"]
        else:
            self.valid_systems += ["daint:login", "daint:gpu",
                                   "dom:login", "dom:gpu"]

        // The prgenv is irrelevant for this case, so just chose one
        self.valid_prog_environs = ["PrgEnv-cray"]
        self.executable = "ls"
        self.executable_opts = ["-al", "/opt/cray/pe/lib64/libsci_a*"]
        self.sanity_patterns = sn.assert_found(f"{lib_name}.so", self.stdout)

After Change

    def __init__(self, lib_name):
        self.descr = "LibSciAcc symlink check of %s" % lib_name

        self.valid_systems = [
            "daint:login", "daint:gpu",
            "dom:login", "dom:gpu",
            "tiger:login", "tiger:gpu"
        ]
        regex = (r"libsci_acc_(?P<prgenv>[A-Za-z]+)_((?P<cver>[A-Za-z0-9]+)_)"
                 r"?(?P<version>\S+)")
        prgenv = re.match(regex, lib_name).group("prgenv")

Instances