d6b1ade52fe313bd853667ea365c110ed06fc74a,src/python/pants/option/parser.py,Parser,_validate,#Parser#Any#Any#,290

Before Change

      if not arg.startswith("--") and len(arg) > 2:
        raise RegistrationError("Multicharacter option {} in {} must begin "
                                "with a double-dash".format(arg, scope_str))
    if "nargs" in kwargs and kwargs["nargs"] != "?":
      raise RegistrationError("nargs={} unsupported in registration of option {} in "
                              "{}.".format(kwargs["nargs"], args, scope_str))
    if "required" in kwargs:
      raise RegistrationError("required unsupported in registration of option {} in "
                              "{}.".format(args, scope_str))

After Change

    if is_boolean_flag(kwargs) and "type" in kwargs:
      error(BooleanOptionType)
    if "implicit_value" in kwargs:
      if is_boolean_flag(kwargs):
        error(BooleanOptionImplicitVal)
      elif kwargs["implicit_value"] is None:
        error(ImplicitValIsNone)
    for kwarg in kwargs:
      if kwarg not in self._allowed_registration_kwargs:
        error(InvalidKwarg, kwarg=kwarg)

Instances