7c355f4ee18b25fcab7c501ba0b531ac1b564350,src/python/pants/pantsd/service/store_gc_service.py,StoreGCService,run,#StoreGCService#,60

Before Change

    self._garbage_collection_thread = threading.Thread(target=self._garbage_collect)
    self._garbage_collection_thread.daemon = False
    self._garbage_collection_thread.start()

    while not self.is_killed:
      time.sleep(1)

After Change

  def run(self):
    Main service entrypoint. Called via Thread.start() via PantsDaemon.run().
    jobs = (self._extend_lease, self._garbage_collect)
    threads = [self._launch_thread(job) for job in jobs]

    while not self.is_killed:
      for thread in threads:
        // If any job threads die, we want to exit the `PantsService` thread to cause
        // a daemon teardown.
        if not thread.isAlive():
          self._logger.warn("thread {} died - aborting!".format(thread))
          return
        thread.join(.1)

Instances