fd1456ac36e0a1ebfb800c9593f1540858ca7bea,src/python/pants/backend/core/tasks/reporting_server.py,KillServer,execute,#KillServer#,114

Before Change

    // There should only be one pidfile, but in case there are many, we kill them all here.
    for pidfile, pid, port in info:
      with open(pidfile, "r") as infile:
        pidstr = infile.read()
      try:
        os.unlink(pidfile)
        pid = int(pidstr)
        os.kill(pid, signal.SIGKILL)
        print("Killed server with {pid} at http://localhost:{port}".format(pid=pid, port=port),
              file=sys.stderr)
      except (ValueError, OSError):

After Change

  def execute(self):
    server = ReportingServerManager(self.context, self.get_options())

    if not server.is_alive():
      logger.info("No server found.")
      return

    pid = server.pid

    try:
      logger.info("Killing server with {pid} at http://localhost:{port}"
                  .format(pid=pid, port=server.socket))
      server.terminate()
    except ReportingServerManager.NonResponsiveProcess:
      logger.info("Failed to kill server with pid {pid}!".format(pid=pid))

Instances