e231c3060cc377553c5668aadd873c3a5fd6fa6c,src/python/twitter/pants/tasks/builddictionary.py,BuildBuildDictionary,_gen_goals_reference,#BuildBuildDictionary#,269

Before Change

  def _gen_goals_reference(self):
    Generate the goals reference rst doc.
    phases = dict()
    for phase, goals in Phase.all():
      phases[phase] = goals

    template = resource_string(__name__,

After Change

    phase_dict = {}
    phase_names = []
    for phase, raw_goals in Phase.all():
      goals = []
      for g in raw_goals:
        // TODO(lahosken) generalize indent_docstring, use here
        doc = (g.task_type.__doc__ or "").replace("\n", " ").strip()
        goals.append(TemplateData(name=g.task_type.__name__, doc=doc))
      phase_dict[phase.name] = TemplateData(phase=phase, goals=goals)
      phase_names.append(phase.name)

    phases = [phase_dict[name] for name in sorted(phase_names, key=str.lower)]

Instances