16d1c7e06a7ba2c9dadb5bbb4a681522aae11985,tests/python/pants_test/cache/test_pinger.py,TestPinger,test_global_pinger_memo,#TestPinger#,51

Before Change

  def test_global_pinger_memo(self):
    fast_pinger = Pinger(timeout=self.fast_timeout_seconds, tries=2)
    slow_pinger = Pinger(timeout=self.slow_timeout_seconds, tries=2)
    self.assertEqual(
      fast_pinger.pings([self.slow_netloc])[0][1], Pinger.UNREACHABLE, msg=self.message)
    self.assertNotEqual(
      slow_pinger.pings([self.slow_netloc])[0][1], Pinger.UNREACHABLE, msg=self.message)

After Change

  @responses.activate
  def test_global_pinger_memo(self):
    urls = [self.slow_url]
    with self.pinger(timeout=0.2, urls=urls) as fast_pinger:
      self.assertEqual(fast_pinger.pings([self.slow_url])[0][1], Pinger.UNREACHABLE)
    with self.pinger(timeout=0.4, urls=urls) as slow_pinger:
      self.assertLess(slow_pinger.pings([self.slow_url])[0][1], Pinger.UNREACHABLE)

  def test_https_external_pinger(self):

Instances